-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete Dataplane package.json and update to 0.43 #23618
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, @lmazuel Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
Swagger Generation Artifacts
|
Generated ApiView
|
ghost
added
the
Cognitive Services
label
Apr 19, 2023
weshaggard
approved these changes
Apr 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks correct but we should also investigate the sdk generation failures as well. Are they also caused by a versioning mis-match or other known issues?
lmazuel
changed the title
MVAD: Delete package.json
Delete Dataplane package.json and update to 0.43
Apr 19, 2023
This was referenced Apr 19, 2023
This was referenced Apr 19, 2023
mikeharder
added a commit
to mikeharder/azure-rest-api-specs
that referenced
this pull request
Apr 21, 2023
This reverts commit b64dd24.
suxi-ms
pushed a commit
that referenced
this pull request
Apr 24, 2023
* Delete package.json * Update to latest TSP deps * Remove all Data-Plane TSP package.json
JoshLove-msft
pushed a commit
to JoshLove-msft/azure-rest-api-specs
that referenced
this pull request
Apr 25, 2023
* Delete package.json * Update to latest TSP deps * Remove all Data-Plane TSP package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per @weshaggard recommendation, this file shouldn't exist